Skip to content

Refactor event prefilters onto fresh candidate collector#230

Merged
chubes4 merged 1 commit intomainfrom
refactor/core-candidate-collector
May 6, 2026
Merged

Refactor event prefilters onto fresh candidate collector#230
chubes4 merged 1 commit intomainfrom
refactor/core-candidate-collector

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented May 6, 2026

Summary

  • Refactors event flyer, vision image, and HTML section selection-time prefilters to use Data Machine core FreshCandidateCollector.
  • Removes the old deprecated event import processed-check helper methods instead of leaving compatibility shims.
  • Adds coverage showing a processed first HTML section does not stop scanning when a later fresh section exists.

Testing

  • php -l on changed PHP files: passed.
  • Pure PHP smoke for EventSectionFinder + FreshCandidateCollector: passed.
  • git diff --check: passed.
  • homeboy test --path /Users/chubes/Developer/data-machine-events@refactor-core-candidate-collector --skip-lint --force-hot -- --filter=EventSectionFinderTest: failed before running tests due a playground/bootstrap database error during Data Machine activation (SQLSTATE[HY000]: General error: 1 no such table: wptests_users).
  • homeboy lint --path /Users/chubes/Developer/data-machine-events@refactor-core-candidate-collector --force-hot: failed with 678 pre-existing lint findings in unrelated TS block files.

Closes #229.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (openai/gpt-5.5)
  • Used for: Refactoring event candidate prefilters onto the Data Machine core fresh-candidate primitive and updating tests. Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented May 6, 2026

Homeboy Results — data-machine-events

Audit

audit — passed

  • test_coverage — 7 finding(s)
  • field_patterns — 4 finding(s)
  • intra-method-duplication — 3 finding(s)
  • dead_code — 2 finding(s)
  • Total: 16 finding(s)

Deep dive: homeboy audit data-machine-events --changed-since 72cd234

Tooling versions
  • Homeboy CLI: homeboy 0.157.1+ddf2948
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 9290561
  • Action: Extra-Chill/homeboy-action@v2

@chubes4 chubes4 merged commit e1f629a into main May 6, 2026
1 check passed
@chubes4 chubes4 deleted the refactor/core-candidate-collector branch May 6, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor event candidate prefilters onto Data Machine fresh-candidate primitive

1 participant